dhaumann added a comment.
What just came to my mind is that this patch also has an issue: If you include a keyword list of a.xml in b.xml, and a.xml uses different word delimiters for the keyword list, then the keywords in b.xml will not be highlighted/detected correctly. Did we think about this when approving this change? What solutions do we have for this? The least we can do is to add this i) to the API documentation, and ii) to the highlighting section in the docbook. That said, the correct fix would be to simply refer to the keyword list of the respective Definition, and if the rule is applied, we should check for the word delimiters of the referenced keyword list... Any other thoughts? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14632 To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann, vkrause Cc: kwrite-devel, vkrause, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
