brute4s99 added a comment.
In D22727#505540 <https://phabricator.kde.org/D22727#505540>, @dfaure wrote: > The Qt documentation says "Warning: Because of differences in the platforms supported by Qt, the semantics of ReadUser, WriteUser and ExeUser are platform-dependent: On Unix, the rights of the owner of the file are returned and on Windows the rights of the current user are returned. " okay, I believe you mean I should leave these changes as-are in the diff. Am I right? > But, wait, this code is mixing "int permissions" (*) with the QFileDevice enum, that doesn't make any sense to me. > > (*) this comes from KIO::put, which takes unix permissions on unix, not sure what it takes on Windows... > > This doesn't match: unix permissions are octal (e.g. group read is 040 in octal), QFileDevice enum is hex (0x040). Okay. I'm still unable to understand where/ how sftp::put() is called, or I would change everywhere it is called, to Qt way of permission extraction. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22727 To: brute4s99, vonreth, dfaure, pino Cc: pino, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
