broulik added inline comments.
INLINE COMMENTS
> icon.cpp:412
> +{
> + reply->deleteLater();
> + if (!reply) {
Move this after the `!reply` check
> icon.cpp:424
> + const QString filename = reply->url().fileName();
> + if (!m_loadedImage.load(reply,
> filename.mid(filename.indexOf(QLatin1Char('.'))).toLatin1().constData())) {
> + qWarning() << "received broken image" << reply->url();
What happens if you leave `format` `nullptr`, does it guess?
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D22952
To: apol, #frameworks, #kirigami
Cc: broulik, plasma-devel, fbampaloukas, domson, dkardarakos, apol,
davidedmundson, mart, hein
