apol added a comment.
+1 LGTM overall INLINE COMMENTS > wallpaperinterface.h:52 > Q_PROPERTY(KDeclarative::ConfigPropertyMap *configuration READ > configuration NOTIFY configurationChanged) > + Q_PROPERTY(bool loading MEMBER m_loading NOTIFY isLoadingChanged) > Use READ isLoading() instead of MEMBER? and unify loading vs isLoading. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22852 To: davidedmundson, #plasma Cc: apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
