dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > kio_sftp.cpp:266 > > - qCDebug(KIO_SFTP_LOG) << "name=" << name << " instruction=" << > instruction << " prompts=" << n; > + qDebug() << "name=" << name << " instruction=" << instruction << " > prompts=" << n; > Use `kdebugsettings` to enable sftp debug output instead of qCDebug->qDebug (which adds a lot of noise to the review) > brute4s99 wrote in kio_sftp.cpp:2050-2051 > it uses buff.st_atime . Since I'm removing use of buff, I'm not sure how to > handle this. For now I've commented out setting the file access time > instruction for now. Just use partFile.fileTime(QFileInfoFileAccessTime) > kio_sftp.cpp:2052 > + // > QFileDevice::FileTime(QFileDevice::FileAccessTime)); > + receivedFile.setFileTime(dt, > QFileDevice::FileTime(QFileDevice::FileModificationTime)); > + } You can remove the FileTime() type conversion, just do setFileTime(dt, QFileDevice::FileModificationTime) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
