meven marked 4 inline comments as done. meven added inline comments. INLINE COMMENTS
> sitter wrote in renamefiledialog.h:72 > You'll also want to override `event` as per > https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B Thanks This is really arcane, I am really not found of C++. > sitter wrote in renamefiledialog.h:76 > You can in fact make the class forward declaration and the member declaration > one line > > `class RenameFileDialogPrivate *const d;` I tried it but it did not work. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17595 To: meven, #frameworks, #dolphin, broulik, ngraham Cc: sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham
