fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> svg.cpp:317
> + const auto match = sizeHintedKeyExpr.match(key);
> + if (match.isValid()) {
> + QString baseElementId = match.captured(3);
`isValid` is always true, you probably want to use `hasMatch` instead.
This is not obvious, I only noticed this because I debugged this error before
(https://phabricator.kde.org/D17359)
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D22147
To: apol, #plasma, #frameworks, fvogt
Cc: fvogt, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
