apol added inline comments.

INLINE COMMENTS

> kdesktopfile.h:27
>  
> +#include <QLoggingCategory>
> +Q_DECLARE_LOGGING_CATEGORY(kconfigLoggingDesktop)

Use ecm_qt_declare_logging_category from cmake.

This should never be in header files too, or it would spill on applications 
otherwise.

See for example how it's done in this same repo on KCONF_UPDATE_LOG.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

Reply via email to