meven commandeered this revision.
meven added a reviewer: ngraham.
meven added inline comments.
INLINE COMMENTS
> kfileplacesmodel.cpp:289
> KFilePlacesItem::createSystemBookmark(d->bookmarkManager,
> - QStringLiteral("Today"),
> I18N_NOOP2("KFile System Bookmarks", "Today"),
> + QStringLiteral("Created
> Today"), I18N_NOOP2("KFile System Bookmarks", "Today"),
>
> QUrl(QStringLiteral("timeline:/today")), QStringLiteral("go-jump-today"));
timeline protocol works on modification date, we should change this to
"Modified Today".
It is a better feature anyway.
> kfileplacesmodel.cpp:292
> KFilePlacesItem::createSystemBookmark(d->bookmarkManager,
> - QStringLiteral("Yesterday"),
> I18N_NOOP2("KFile System Bookmarks", "Yesterday"),
> + QStringLiteral("Created
> Yesterday"), I18N_NOOP2("KFile System Bookmarks", "Yesterday"),
>
> QUrl(QStringLiteral("timeline:/yesterday")),
> QStringLiteral("view-calendar-day"));
same here
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7446
To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel,
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik,
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice,
LeGast00n, fbampaloukas, alexde, feverfew, michaelh, navarromorales, firef,
ngraham, andrebarros, bruns, emmanuelp, mikesomov
