bruns added a comment.
In D20967#480338 <https://phabricator.kde.org/D20967#480338>, @bcooksley wrote: > Please note that there are very few people involved with Windows builds (despite the number of projects that make use of them in general) so people may not always have the ability to respond to every review request. > That is why the CI system monitors the state of code and can catch issues as they happen. If there are OS specific changes, and they are added to the subscribers list, they damn should. The CI catches some errors, but not everything. Also, this code is not covered by the unit tests on Windows, so even when the CI shows green this just means it compiles. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: bcooksley, arrowd, #freebsd, #windows, kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
