apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS
> bruns wrote in svg.cpp:123 > Are you sure you uploaded the right diff? No const static, Q_ASSERT ... static isn't necessary, QRegularExpression already has internal regex compilation optimisations we can leverage. Does the assert bother you? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21788 To: apol, #plasma, #frameworks Cc: bruns, kde-frameworks-devel, LeGast00n, michaelh, ngraham
