bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS
> poboiko wrote in modifiedfileindexer.cpp:68 > Does it also changes behavior of ModifiedFileIndexer? What happened to > symlinks before? It depends on the state of the PendingFileQueue: - when an item is not in the list of recent files, and is new, an `indexNewFile` signal is emitted, we end up in the NewFileIndexer - otherwise, on a 'created' event a `indexModifiedFile` signal is emitted -> ModifiedFileIndexer so, on mkdir target; mkdir test; sleep ... rmdir test; ln -s target test we get a deleted and a created event, where the latter ends up in the ModifiedFileIndexer, adding a symlink to the index. For e.g. the UnindexedFileIndexer, symlinks are omitted using `QDir::NoSymlinks`. That said, NewFileIndexer should also check for symlinks. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21706 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
