arrowd added a comment.
It compiles now, but the test fails: ********* Start testing of UserMetaDataWriterTest ********* Config: Using QtTest library 5.12.2, Qt 5.12.2 (x86_64-little_endian-lp64 shared (dynamic) release build; by Clang 8.0.0 (tags/RELEASE_800/final 356365)) PASS : UserMetaDataWriterTest::initTestCase() FAIL! : UserMetaDataWriterTest::test() 'md.queryAttributes(UserMetaData::Attribute::All) & UserMetaData::Attribute::Tags' returned FALSE. () Loc: [/home/arr/projects/kfilemetadata/autotests/usermetadatawritertest.cpp(55)] PASS : UserMetaDataWriterTest::cleanupTestCase() Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 1ms ********* Finished testing of UserMetaDataWriterTest ********* I also had to do this to enable the test: diff --git a/autotests/CMakeLists.txt b/autotests/CMakeLists.txt index 49824ba..994c7bc 100644 --- a/autotests/CMakeLists.txt +++ b/autotests/CMakeLists.txt @@ -220,7 +220,7 @@ endif() # # UserMetaData # -if(CMAKE_SYSTEM_NAME MATCHES "Linux") +if(UNIX) kde_enable_exceptions() ecm_add_test(usermetadatawritertest.cpp ../src/usermetadata.cpp TEST_NAME "usermetadatawritertest" INLINE COMMENTS > bruns wrote in xattr_p.h:231 > Why ditto? Right, no need to change there. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: arrowd, #freebsd, #windows, kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams