drosca accepted this revision. drosca added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > gattapplication.h:85 > + */ > + virtual QDBusObjectPath objectPath() const; > + This should be protected > gattapplication.h:96 > + */ > + DBusManagerStruct getManagedObjects() const; > + This doesn't need doc anymore. > gattcharacteristicadaptor.cpp:62 > + m_gattCharacteristic->writeValue(value); > +} > +void GattCharacteristicAdaptor::StartNotify() newline > gattservice.h:50 > + */ > + GattService(const QString &uuid, bool isPrimary, GattApplication > *parent); > + explicit REPOSITORY R269 BluezQt BRANCH ble_gatt REVISION DETAIL https://phabricator.kde.org/D21584 To: mweichselbaumer, drosca Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
