chinmoyr updated this revision to Diff 59290.
chinmoyr added a comment.

  - int -> ActionType
  - separated the logic in dropPrivileges() to two parts
  - accepting mode argument in mkdir
  - used *at() functions
  - minor cosmetic changes
  
  @mgerstner In case of rename, when owners are different I am trying to rename 
twice. First after changing euid
  and egid to the owner of src's parent dir and then the owner of dest's parent 
dir, hoping that at least one of 
  them is a privileged user. Do you think it's a good idea?

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14467?vs=38719&id=59290

BRANCH
  arcpatch-D14467

REVISION DETAIL
  https://phabricator.kde.org/D14467

AFFECTED FILES
  src/ioslaves/file/file_p.h
  src/ioslaves/file/kauth/filehelper.cpp

To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin
Cc: mgerstner, fvogt, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

Reply via email to