broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> datamodel.cpp:197
> +    sort(sortColumn(), order);
> +}
> +

please add a `sortOrderChanged` signal (in a separate patch, if you feel like 
it)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21419

To: davidedmundson, #plasma, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

Reply via email to