bruns added a comment.

  LGTM
  
  currently, GCC thows some "0 for nullptr" and "missing override" warnings, 
are you going to address these (new SR)?
  
  Also, Qt recommends deriving from Q**Styled**ItemDelegate

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21354

To: ngraham, #frameworks, apol
Cc: bruns, aacid

Reply via email to