bruns added inline comments. INLINE COMMENTS
> sambausershareplugin.cpp:126 > + connect(propertiesUi.sambaChk, &QCheckBox::toggled, > + this, &SambaUserSharePlugin::changed); > + connect(propertiesUi.sambaNameEdit, &QLineEdit::textChanged, I think instead of emiting `KFilePropertiesPlugin::changed()` it would be better to call `setDirty()` in the slots. See https://api.kde.org/frameworks/kio/html/classKPropertiesDialogPlugin.html#af25f4b84d915dcc005a203a637ad0511 REPOSITORY R432 File Sharing (Samba) integration REVISION DETAIL https://phabricator.kde.org/D21354 To: ngraham, #frameworks, apol Cc: bruns, aacid
