hallas added a comment.
In D20938#459628 <https://phabricator.kde.org/D20938#459628>, @bruns wrote: > In D20938#459627 <https://phabricator.kde.org/D20938#459627>, @hallas wrote: > > > In D20938#459218 <https://phabricator.kde.org/D20938#459218>, @bruns wrote: > > > > > Solid already has a working implementation for reading from /proc/mounts, the fstab backend. > > > > > > Contrary to this code, the fstab backend does not poll every second using a timer, but correctly uses /proc/mounts changes notification via blocking read. > > > > > > The only thing needed is a small extension to also hand out information for other filesystems than nfs and cifs. > > > > > > This was exactly the kind of review comments I was looking for :D Let me take a new stab at this where I extend the current fstab with this functionality so we can see how that solution compares to this one. > > > I already have/had some code for this laying on my hard disk, I will post this as a WIP later today ... Great! Then I will hold my horses a bit! REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20938 To: hallas, #frameworks, ngraham, elvisangelaccio, broulik, bruns Cc: svuorela, nicolasfella, ivan, kde-frameworks-devel, michaelh, ngraham, bruns
