pino requested changes to this revision.
pino added a comment.
Also, there was feedback it was still not taken care.
Please do not ping on pathed when you are requested for changes, and still do
not do them.
INLINE COMMENTS
> kpropertiesdialog.cpp:2111
> + mode_t itemPermission = properties->item().permissions();
> + qint64 perm = static_cast<qint64>(itemPermission);
> + QString octal = QString::fromLatin1("Octal: %1").arg(perm, 0, 8);
why the cast to qint64?
> kpropertiesdialog.cpp:2112
> + qint64 perm = static_cast<qint64>(itemPermission);
> + QString octal = QString::fromLatin1("Octal: %1").arg(perm, 0, 8);
> +
why this string includes the untranslated label?
> kpropertiesdialog.cpp:2115
> + // Add Octal permissions
> + l = new QLabel(i18n("%1", octal), gb);
> + gl->addWidget(l, 0, 0, Qt::AlignRight);
the translatable label must be here instead
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20735
To: shubham, ngraham, pino, #vdg
Cc: mmustac, pino, kde-frameworks-devel, michaelh, ngraham, bruns
