dfaure created this revision. dfaure added reviewers: sitter, apol. dfaure requested review of this revision.
TEST PLAN (to mimick CI) : make uninstall in kpackage and then QT_LOGGING_RULES='*=true' XDG_DATA_DIRS=$KDEDIR/share /d/kde/build/5/frameworks/kpackage/bin/kpackagetool5 --appstream-metainfo . --appstream-metainfo-output /tmp/a.xml For some reason kpackagetool5 creates a KPluginMetaData from metadata.desktop in 3 different places of the code (Package::setPath calls metadata() but then it deletes it!, metadata() again later, and PackageTool::showAppstreamInfo) Before: Unknown property type for key "X-Plasma-MainScript" -> falling back to string After: No more warning BRANCH master REVISION DETAIL https://phabricator.kde.org/D20758 AFFECTED FILES src/kpackagetool/kpackagetool.cpp To: dfaure, sitter, apol Cc: #frameworks
