dfaure created this revision. dfaure added reviewers: mart, arichardson, davidedmundson, mpyne. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision.
REVISION SUMMARY If we parsed the service type from a qrc file (like kpackagetool does) then it's wrong to later on say we can't find the file defining that service type. TEST PLAN make uninstall in kpackage, then XDG_DATA_DIRS=$KDEDIR/share <builddir>/bin/kpackagetool5 --appstream-metainfo . --appstream-metainfo-output /tmp/a.xml Used to say: Unable to find service type for service "KPackage/Generic" listed in "./metadata.desktop" even though it parsed ":/kservicetypes5/kpackage-generic.desktop" before. For this we need to extract and store the name of the service type we're parsing (key "X-KDE-ServiceType"). REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20748 AFFECTED FILES src/lib/plugin/desktopfileparser.cpp src/lib/plugin/desktopfileparser_p.h To: dfaure, mart, arichardson, davidedmundson, mpyne Cc: kde-frameworks-devel, michaelh, ngraham, bruns
