pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed.
Parsing the result of KFileItem::permissionsString() is a rather bad idea, especially considering that KFileItem already provides mode() and permissions(). Also, the placing of the label is completely off. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20735 To: shubham, ngraham, pino Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns