ngraham added a comment.

  This patch doesn't apply:
  
     INFO  Base commit is not in local repository; trying to fetch.
    Created and checked out branch arcpatch-D20693.
    Checking patch src/ui/imagepreviewwidget_p.h...
    Checking patch src/ui/imagepreviewwidget.cpp...
    Checking patch data/thumb_frame.png...
    error: the patch applies to 'data/thumb_frame.png' 
(afaf432793864e1fb3f1fc27aa1d53689f2243b5), which does not match the current 
contents.
    error: data/thumb_frame.png: patch does not apply
    Checking patch data/CMakeLists.txt...
    Applied patch src/ui/imagepreviewwidget_p.h cleanly.
    Applied patch src/ui/imagepreviewwidget.cpp cleanly.
    Applied patch data/CMakeLists.txt cleanly.
    
     Patch Failed! 
    Usage Exception: Unable to apply patch!
  
  Also it would be helpful if you used `arc` for your patches, since then you 
can see the context here in the web UI: 
https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches
  
  Additionally, it's nice if you can add a screenshot to the Test Plan section 
for patches that involve UI changes: 
https://community.kde.org/Infrastructure/Phabricator#Include_some_screenshots

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D20693

To: leinir, #knewstuff, ngraham, sitter
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

Reply via email to