dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kmountpoint.cpp:164
> }
> - // TODO: Strip trailing '/' ?
> + mountedFrom =
> mountedFrom.left(mountedFrom.lastIndexOf(QLatin1Char('/')));
> }
That would turn "/boot/efi" into "/boot" !!
I wonder, did kmountpointtest still pass?
You want something like this instead:
if (mountedFrom.endsWith('/')) {
mountedFrom.chop(1);
}
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20625
To: shubham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
