broulik requested changes to this revision.
broulik added a comment.
This revision now requires changes to proceed.
Instead of swapping out one random number for another, please correctly
calculate the implicit size of the page, like `GridViewKCM` does:
Something like
implicitHeight: Math.min(flickable.contentHeight, Kirigami.Units.gridUnit *
20)
+ topPadding + bottomPadding
+ (header && header.visible ? header.height +
header.topPadding + header.bottomPadding : 0)
+ (footer && footer.visible ? footer.height +
footer.topPadding + footer.bottomPadding : 0) + Kirigami.Units.gridUnit
plus the page's own padding or so. :)
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D20283
To: ngraham, #plasma, mart, broulik
Cc: broulik, davidedmundson, GB_2, kde-frameworks-devel, michaelh, ngraham,
bruns
