kossebau added inline comments.

INLINE COMMENTS

> katedialogs.cpp:1294
>      } else {
> -        QAction * closeFile = new QAction(i18n("&Close"), this);
> +        QAction * closeFile = new QAction(i18n("&Close file"), this);
>          
> closeFile->setIcon(QIcon::fromTheme(QStringLiteral("document-close")));

Given this text ends on a button , use "&Close File".
See also https://hig.kde.org/style/writing/capitalization.html

More perfect might be even to use User Interface Markers in the comment, so 
translators have a clue what capitalization style they would prefer for their 
locale ->
`i18nc("@action:button", "&Close file")`
See also https://api.kde.org/frameworks/ki18n/html/prg_guide.html#good_ctxt

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20542

To: meven, #ktexteditor
Cc: kossebau, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

Reply via email to