meven marked 2 inline comments as done.
meven added inline comments.

INLINE COMMENTS

> meven wrote in file.cpp:850-870
> Do you mean the struct keyword in the argument in "inline static uint16_t 
> stat_mode(struct statx buf) { return buf.stx_mode; } " for instance ?

Unfortunately this is not possible here : statx is also a function, the 
compiler gets messed up when removing the struct keyword interpreting it as a 
function call.

> /file/file.cpp:850:34: warning: inline variables are only available with 
> -std=c++17 or -std=gnu++17
> 
>   377   │  inline static uint16_t stat_mode(statx buf) { return buf.stx_mode; 
> }

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D20096

REVISION DETAIL
  https://phabricator.kde.org/D20096

To: meven, #frameworks, dfaure, fvogt, bruns, broulik
Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, 
bruns

Reply via email to