kossebau added a comment.
In D20166#443916 <https://phabricator.kde.org/D20166#443916>, @ngraham wrote: > In D20166#443781 <https://phabricator.kde.org/D20166#443781>, @kossebau wrote: > > > If so, I would propose to merge it after KDE Frameworks 5.57 has been branched this WE, i.e. merge Friday next week for another 7 days of consideration, but with some weeks before the next release so people using master can test-drive things some more before release, not only me :) > > > Makes sense to me. That said, I just gave this a whirl and got a CMake error immediately: > > CMake Error at src/desktoptheme/CMakeLists.txt:30 (message): > No files passed when calling plasma_install_desktoptheme_svgs. > Call Stack (most recent call first): > src/desktoptheme/oxygen/CMakeLists.txt:5 (plasma_install_desktoptheme_svgs) > Yes, because an important hint was already moved out of sight, so let my recite my first comment: The SVGZ -> SVG conversion of all files not included in this uploaded patch, to keep it reviewable. Locally do this: Store a file `svgztosvg.sh` with this content in `src/desktoptheme`: #!/bin/sh SVGZ=$1 if [ ! -f "$SVGZ" ]; then echo "File not found: \"$SVGZ\"" exit 1 fi SVG=${SVGZ%.svgz}.svg zcat $SVGZ > $SVG rm $SVGZ Then on the commandline do this: cd plasma-framework/src/desktoptheme find . -name "*.svgz" -exec sh svgztosvg.sh {} \; Once done, do e.g. this to restore SVGZ files: find . -name "*.svg" -exec rm {} \; git checkout air breeze oxygen REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20166 To: kossebau, #plasma, #vdg Cc: bruns, GB_2, ndavis, ngraham, fvogt, kde-frameworks-devel, michaelh
