apol added a comment.
etc.
INLINE COMMENTS
> datamodel.cpp:309
>
> - foreach (const QString &key, m_dataSource->data()->keys()) {
> + const auto lst = m_dataSource->data()->keys();
> + for (const QString &key : lst) {
same?
Also this should clearly be using iterators, no?
> tooltipdialog.cpp:59
> //HACK: search our own import
> - foreach (const QString &path,
> m_qmlObject->engine()->importPathList()) {
> + const auto lst = m_qmlObject->engine()->importPathList();
> + for (const QString &path : lst) {
same?
If we have to open an incidence for every comment this gets exhausting.
> containment.cpp:299
> }
> - foreach (Applet *applet, Containment::applets()) {
> + const auto lstApplets = Containment::applets();
> + for (Applet *applet : lstApplets) {
just applets?
> corona.cpp:132
> c->Applet::d->immutability = Types::Mutable;
> - foreach (Applet *a, c->applets()) {
> + const auto lstApplet = c->applets();
> + for (Applet *a : lstApplet) {
applets?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D19913
To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
