bruns added inline comments.
INLINE COMMENTS
> propertyinfotest.cpp:97
> QCOMPARE(framerate.formatAsDisplayString(QVariant(23)),
> QStringLiteral("23 fps"));
> - QCOMPARE(framerate.formatAsDisplayString(QVariant(23.976)),
> QStringLiteral("23.98 fps"));
> + QCOMPARE(framerate.formatAsDisplayString(QVariant(23.976)),
> QString(QLocale().toString(23.98) + QStringLiteral(" fps")));
>
This will of course fail as soon as someone translates fps, e.g. german "B/s",
even more in RTL locales.
Probably the better solution is to provide the whole string verbatim, and mark
it with i18n. Until then, tests should be run with an en or C locale.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D20012
To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh,
astippich, spoorun, ngraham, bruns, abrahams
