ngraham created this revision. ngraham added reviewers: Frameworks, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision.
REVISION SUMMARY Currently, when using single-click mode, when you're saving a file and click on an existing file, that file is highlighted and the filename field become focused so you can quickly rename it. This patch makes that behavior work for double-click mode, too TEST PLAN When using single-click: - Save a file, single-click on an existing file in the file dialog - Observe that current behavior has not changed - Open a file, single-click on an existing file in the file dialog - Observe that current behavior has not changed - Save a file, double-click on an existing file in the file dialog - Observe that current behavior has not changed When using double-click: - Save a file, single-click on an existing file in the file dialog - **Observe that the filename gets selected just like in single-click mode** - Open a file, single-click on an existing file in the file dialog - Observe that current behavior has not changed - Save a file, double-click on an existing file in the file dialog - Observe that current behavior has not changed REPOSITORY R241 KIO BRANCH highlight-filename-after-click-when-saving (branched from master) REVISION DETAIL https://phabricator.kde.org/D19849 AFFECTED FILES src/filewidgets/kfilewidget.cpp To: ngraham, #frameworks, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns