ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed.
Neato! Looks pretty handy. Two issues I found: - generate_web_data.sh isn't executable - I'd like to see this run as part of the build process, so that `index.html` gets updated automatically, and so running it doesn't pollute your source folder since you're of course doing out-of-source builds :) Then you don't have to add the generated text files to .gitignore. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns
