loh.tar updated this revision to Diff 53574. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment.
>> me wrote: >> >> 2. Please test with right to left text layout, and mixed text layout. > > Can't say what is to be expect in such case, so test is difficult for me OK. It pointed out that these RTL implementation is slightly buggy in Kate/Qt and therefore I was lost. After recent "forced" request to implement it anyway and to ignore my inner aversions to do it, I found good old BUG 165397. These test data and comments helped me to judge now that this patch works as best as it is possible. - Remove pointless "m_viewInternal->m_view->" - Re-arrange if cases, looks now similar as rest of the code - Use QFETCH, but not for all needed data. Requests to fix that will ignored :p REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19621?vs=53540&id=53574 REVISION DETAIL https://phabricator.kde.org/D19621 AFFECTED FILES autotests/src/kateview_test.cpp autotests/src/kateview_test.h src/view/kateview.cpp To: loh.tar, #ktexteditor Cc: cullmann, brauch, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, bruns, demsking, sars
