sh-zam reopened this revision. sh-zam added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > CMakeLists.txt:74 > add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x050d00) > +add_definitions(-DQT_NO_FOREACH) > Removing this line is doesn't allow build to succeed, I had to comment this line to make it successful. My build log: F6659392: build.log <https://phabricator.kde.org/F6659392> I am using build_kf5.sh <https://github.com/KDE/kstars/blob/master/packaging/android/build_kf5.sh> to build the framework REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D19534 To: mlaurent, dfaure Cc: sh-zam, kde-frameworks-devel, michaelh, ngraham, bruns