dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land.
@ngraham I'm not convinced. Warning users that an operation can't be undone makes sense, but canceling in the middle of the operation is not usually something to warn about. It's nice to handle it better, but I wouldn't bother the user with "you know, if you cancel, you'll be in trouble". Well, yes, I'm OVERWRITING a file. If I'm too slow to cancel, I'll have the same trouble too. Anyhow, that's for the GUI side of things, this commit seems fine in itself. REPOSITORY R241 KIO BRANCH arcpatch-D10663 REVISION DETAIL https://phabricator.kde.org/D18904 To: chinmoyr, dfaure, dmitrio Cc: kde-frameworks-devel, ngraham, michaelh, bruns