kossebau added a subscriber: vkrause. kossebau added inline comments. INLINE COMMENTS
> kossebau wrote in textcreator.cpp:169 > Good idea. Hm, > `highlightingTheme.backgroundColor(KSyntaxHighlighting::Theme::Normal)` > returns black for me, and there is a comment for > `Theme::backgroundColor(TextStyle) const` saying > "0 is returned for styles that do not specify a background color, use the > default background color in that case. " > No clue yet what is meant by "default background color". Not sure I want to > use the `Theme::editorColor(EditorColorRole role) const` with > `BackgroundColor`? @vkrause Can you help here and tell what one is intended to use? > cfeck wrote in textcreator.cpp:169 > KSyntaxHighlighting::Theme also provides a background color. Can that be used > instead of the hardcoded 245? I cannot remember reason why I disabled (or > never enabled) the QPalette code; I suggest to remove it. @cfeck: I would do the remove of the qpalette in a separate commit then later. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19432 To: kossebau, broulik Cc: vkrause, cfeck, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
