cgiboudeaux added inline comments. INLINE COMMENTS
> CMakeLists.txt:68 > set_property(TARGET SyntaxHighlightingData PROPERTY > POSITION_INDEPENDENT_CODE 1) > +target_link_libraries(SyntaxHighlightingData PRIVATE Qt5::Core) This is causing a build issue (at least) with CMake 3.10: > CMake Error at data/CMakeLists.txt:68 (target_link_libraries): > > Object library target "SyntaxHighlightingData" may not link to anything. OBJECT targets must not link to anything [1] > An object library compiles source files but does not archive or link their > object files into a library. The CMake doc < 3.11 also mentions "Object libraries cannot be linked." [1] https://cmake.org/cmake/help/v3.14/command/add_library.html#object-libraries REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18996 To: davschul, vkrause Cc: cgiboudeaux, cullmann, kwrite-devel, kde-frameworks-devel, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars, dhaumann
