dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> krcc.cpp:147
>  {
> -    Q_FOREACH (const QString &fileName, dir.entryList()) {
> +    for (const QString &fileName : dir.entryList()) {
>          const QString entryPath = dir.path() + QLatin1Char('/') + fileName;

move to temp var to avoid detaching?

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D19251

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Reply via email to