lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.
LGTM!. Annoyed me for a long time (and made hard to debug some issues).
INLINE COMMENTS
> externalextractor.cpp:120
> extractorProcess.start(d->mainPath, QStringList(), QIODevice::ReadWrite);
> + bool started = extractorProcess.waitForStarted();
> + if (!started) {
Will this block anything?
REPOSITORY
R286 KFileMetaData
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D19108
To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich, lbeltrame
Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich,
spoorun, ngraham, bruns, abrahams
