poboiko added inline comments. INLINE COMMENTS
> bruns wrote in kinotify.cpp:390 > yes, but just `const QString fname = ...` Right, sorry, misprinted. Actually, since there are a lot of `decodeName` calls around, probably it would be better to decode it just once, right before `event->mask` matching then, and then pass it everywhere? (less code duplication & mutliple calls if `mask` matches several events...) REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18698 To: poboiko, #baloo, #frameworks, ngraham, bruns Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams
