pino added inline comments.
INLINE COMMENTS
> pdfcreator.cpp:45-46
> +{
> + Q_UNUSED(width);
> + Q_UNUSED(height);
> +
please honor the requested width and height
> pdfcreator.cpp:49
> + QScopedPointer<Document> document;
> + document.reset(Document::load(QFile::encodeName(path)));
> +
Document::load() takes a QString, so do not encode the filename (which will be
encoded twice)
> pdfthumbnail.desktop:6
> +X-KDE-ServiceTypes=ThumbCreator
> +MimeType=application/pdf;application/x-dvi;application/postscript;
> +
definitely neither DVI nor PS...
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D18883
To: broulik, dfaure, aacid, jtamate
Cc: pino, ltoscano, kde-frameworks-devel, kfm-devel, alexde, feverfew,
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns,
emmanuelp, mikesomov
