mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > baloo.categories:4 > kf5.kio.kio_timeline Baloo Timeline (KIO) DEFAULT_SEVERITY [WARNING] > IDENTIFIER [Baloo::KIO_TIMELINE] > +org.kde.baloo.engine Baloo engine debug Please use new syntax see previous line. > CMakeLists.txt:31 > + BALOO_ENGINE_SRCS > + HEADER "enginedebug.h" > + IDENTIFIER "ENGINE" which files uses it ? you generate it but it seems that you don't use it in file no ? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18873 To: valeriymalov, #baloo, mlaurent Cc: mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams