ahmadsamir updated this revision to Diff 50486. ahmadsamir retitled this revision from "Don't fail if defaultLanguage dictionary can't be loaded" to "Display an error message if loading a dictionary fails". ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this revision. ahmadsamir removed a reviewer: loh.tar. ahmadsamir removed a subscriber: pino. ahmadsamir added a comment.
Rework the patch: - so as not to change the config file without the user's intervention - core libs shouldn't depend on Gui bits REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18317?vs=49714&id=50486 BRANCH invalid-defaultLanguage (branched from master) REVISION DETAIL https://phabricator.kde.org/D18317 AFFECTED FILES src/core/loader.cpp src/core/loader_p.h src/ui/dictionarycombobox.cpp src/ui/dictionarycombobox.h To: ahmadsamir, sandsmark, loh.tar Cc: kde-frameworks-devel, michaelh, ngraham, bruns, pino
