ngraham requested changes to this revision. ngraham added reviewers: Frameworks, Dolphin. ngraham added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > knewfilemenu.cpp:907 > if (name.contains(QLatin1Char('/'))) { > + // Allow creating directory tree on Windows > // If the name contains any slashes, use mkpath so that a/b/c works. If Windows allows slashes in the filename, shouldn't they just be a part of the filename and not create a directory tree? If so, then we don't even need this `#ifdef` condition at all; `KIO::mkdir(url);` will take care of the behavior on each individual platform REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns