romangg requested changes to this revision.
romangg added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> test_display.cpp:223
> +    QVERIFY(runtimeDir.exists());
> +    QVERIFY(!runtimeDir.exists("wayland-0"));
> +    QVERIFY(!runtimeDir.exists("wayland-1"));

This fails when one tries to run the test inside another Wayland session, which 
already uses the wayland-0 socket name.

What you could do here is loop until you find the first non-existing 
`wayland-x` in the runtime dir. Then do it one more time from there until you 
find the second `wayland-y`. Remember x,y and compare these below against the 
created socket names.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17122

To: fvogt, #kwin, #plasma, romangg
Cc: zzag, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

Reply via email to