loh.tar updated this revision to Diff 50082.
loh.tar retitled this revision from "ViewPrivate: Make applyWordWrap() more 
comfortable" to "ViewPrivate: Make 'Apply Word Wrap' more comfortable".
loh.tar added a comment.


  - Use std::unique_ptr for the cursor
  - Oops!? Use 'if' instead of unneeded 'while' loop which also avoid 'goto'
  
  Regarding autotest point me to some blue print and I will try to do it.
  
  Should you love it as it is and intend to commit, I would update the summary 
section before and look at that "What this" hint.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17949?vs=48639&id=50082

REVISION DETAIL
  https://phabricator.kde.org/D17949

AFFECTED FILES
  src/view/kateview.cpp
  src/view/kateview.h

To: loh.tar, #ktexteditor, mwolff
Cc: dhaumann, cullmann, mwolff, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars

Reply via email to