cullmann added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in katedialogs.cpp:1130
> > you can either cumulatively add the delta values from events until the
> > value of 120 is reached
>
> I don't know what is unclear, it should be 120 not any other value.
>
> if (object == m_ModifiedUp) {
> m_deltaUp += event->delta();
> if (m_deltaUp >= 120) {
> m_ModifiedUp->click();
> }
>
> and so on. If not do it right you can end up in partial value when it used
> finer-resolution wheels and mishmash.
I think 120 would be better to use, as that is the value one should start to
handle given the docs.
I would not use a static delta but just have the delta as member of the class.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D18164
To: loh.tar, #ktexteditor
Cc: cullmann, anthonyfieroni, kwrite-devel, kde-frameworks-devel, #ktexteditor,
hase, michaelh, ngraham, bruns, demsking, sars, dhaumann
