ngraham added a comment.
In D17623#380204 <https://phabricator.kde.org/D17623#380204>, @ndavis wrote: > In D17623#378670 <https://phabricator.kde.org/D17623#378670>, @ngraham wrote: > > > apps/32/yast-checkmedia.svg preferences/32/preferences-devices-drive-optical-ok.svg > > > Why `ok`? This is a preferences icon, so it doesn't make sense for there to be preferences about `ok`, which usually represents a state. My intention was to have the last word reflect the checkmark (presumably a version with an X could be made). Another word could work too. >> apps/32/yast-create-new-vm.svg preferences/32/preferences-vm-add.svg >> apps/32/yast-vm-install.svg preferences/32/preferences-vm-install.svg >> apps/32/yast-vm-migrate.svg preferences/32/preferences-vm-migrate.svg >> apps/32/yast-vm.svg preferences/32/preferences-vm.svg > > Is `vm` too short? Could `virtualization` be better? `preferences-vm-add` seems awfully similar to an action icon for a preferences icon, but that's because of how the icon is used in the first place. `virtualization` seems fine, yeah. >> apps/32/yast-device-tree.svg preferences/32/preferences-devices.svg > > This icon represents a tree of devices in a graph of the system's drive partitions. I'm not sure if it's good as an icon for just any `devices`. `preferences-devices-tree.svg` then? >> apps/32/yast-disk.svg preferences/32/preferences-devices-drive-harddisk-partitions.svg > > This icon currently uses openSUSE colors to represent the YaST Partitioner. I might have to change the colors to make it a KDE partition preferences icon. Ok. >> apps/32/yast-docker.svg preferences/32/preferences-system-docker.svg > > Should this be `preferences-virtualization-docker`? +1 >> apps/32/yast-dsl.svg preferences/32/preferences-system-network-modem.svg > > I was planning on turning this into a 64px device icon (`network-rj11-female`). If I were to do an actual modem icon, I would pick something that looks more like a modem. Lots of modems don't have RJ11 (DSL/Telephone wire) ports and lots of devices that have RJ11 ports are not modems. I've had some issues with getting 64px icons to work though. They should work and I see no reason for them not to since I've seen them work, but whenever I try, the icons fallback to hicolor. I'll have to talk to LCP or YaST devs about that. So `preferences-system-network-rj11-female.svg` then? >> apps/32/yast-lan.svg preferences/32/preferences-system-network-ethernet.svg > > Same deal as the RJ11 icon, except it's RJ45. However, the name makes sense for a preferences icon specifically for ethernet, whatever that would be used for. Perhaps it could be `preferences-system-network-rj45-female.svg`, and create a symlink to it called `preferences-system-network-ethernet.svg`? >> apps/32/yast-hwinfo.svg preferences/32/preferences-system-hwinfo.svg > > This is a 32px version of the existing `hwinfo` icon since it looks blurry as hell when scaled down to 32px. Right. >> apps/32/yast-instserver.svg preferences/32/preferences-system-network-server-install.svg > > `instserver` is for providing installation repos, not specifically for installing a server. Is `install` good enough? Maybe `preferences-system-network-server-installation` then? Install servers aren't uncommon. >> apps/32/yast-journal.svg preferences/32/preferences-book.svg > > This is an icon for the systemd journal. It could probably be replaced with a 32px version of the KSystemLog icon or something similar. Sounds good to me. >> apps/32/yast-nis.svg preferences/32/preferences-desktop-user-nis.svg > > Why is this `preferences-desktop-user-nis` and LDAP `preferences-system-network-ldap`? They both have similar functions, except LDAP is a more secure replacement for NIS. We could do `preferences-system-network-nis`. >> apps/32/yast-snapper.svg preferences/32/preferences-devices-drive-harddisk-snapper.svg > > Snapper is a system snapshotting program, not a type of device. I was just re-using the naming style of the other icons that have a hard disk with an icon in it. Ideas? > > >> apps/32/yast-sudo.svg preferences/32/preferences-desktop-user-sudo.svg > > This is for configuring `sudo`. It doesn't have anything to do with a specific user or the desktop. `preferences-system-user-sudo`? >> apps/32/yast-vpn.svg preferences/32/preferences-web-browser-vpn.svg > > Generally, VPNs are handled by `plasma-nm`, not anything to do with web browsers specifically. Perhaps I could have picked an icon that isn't consistent with the `preferences-web-browser-*` icons. Yeah, I was just re-using the naming style of the icons you made it look similar to. It could be `preferences-system-network-vpn`, but maybe it should have a different visual style then> >> apps/32/yast-wol.svg preferences/32/preferences-web-browser-power.svg > > This is Wake-on-Lan <https://en.wikipedia.org/wiki/Wake-on-LAN>. It doesn'thave anything to do with web browsers. Perhaps I could have picked an icon that isn't consistent with the `preferences-web-browser-*` icons. Same thing as the vpn icon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns
