anthonyfieroni added inline comments. INLINE COMMENTS
> katesearchbar.cpp:83 > +typedef QHash<const KateSearchBar *, KateSearchBarPrivate *> > KateSearchBarPrivateHash; > +static KateSearchBarPrivateHash KateSearchBarPrivateData; > +Q_GLOBAL_STATIC(KateSearchBarPrivateHash, d_func) It's not needed, right? > katesearchbar.cpp:97-99 > + KateSearchBarPrivate *ret = d_func()->value(foo); > + delete ret; > + d_func()->remove(foo); Use directly delete d_func()->take(foo); REVISION DETAIL https://phabricator.kde.org/D17459 To: loh.tar, #ktexteditor, #vdg, cullmann Cc: anthonyfieroni, brauch, cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars, dhaumann
